[breaking] Refactoring of board autodetection #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctedError - The message formatting has been fixed - The errors now accepts a *rpc.Port instead of a *discovery.Port - The new error NoBoardsDetectedError has been added
fqbn -> fqbnArg port -> portArgs detectedFqbn -> fqbn discoveryPort -> port
fqbn -> fqbnArg port -> portArgs discoveryPort -> port
fqbn -> fqbnArg port -> portArgs discoveryPort -> port
- use `board.List()` instead of implementing a duplicate of it - factored the logic that calculates FQBN, Port and possibly autodetects FQBN, so we have a single implementation for all commands of the cli.
Because it's no more needed
cmaglie
force-pushed
the
factoring_arguments
branch
from
9102b90 to
3e0cf80
Compare
cmaglie
force-pushed
the
factoring_arguments
branch
from
839291f to
d7d5411
Compare
umbynos
reviewed
Apr 28, 2022
umbynos
reviewed
Apr 28, 2022
umbynos
approved these changes
Apr 28, 2022
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Some redundancy and wrong usage of the arduino-cli golang modules are fixed:
DetectConnectedBoardhas been removed since is a duplicate of the already implementedboard.List--discovery-timeoutflag has been factored.What is the current behavior?
No changes in behavior
Does this PR introduce a breaking change, and is
titled accordingly?
Yes, docs have been updated.
Other information:
This PR is a prerequisite for profiles.